Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce --ignore-codes in CLI #856

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Introduce --ignore-codes in CLI #856

merged 7 commits into from
Jan 17, 2025
+72 −0

Conversation

ernilambar
Copy link
Member

Fixes #769

@ernilambar ernilambar marked this pull request as ready for review January 16, 2025 11:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy
Copy link
Member

--exclude-checks makes sense because it excludes some checks from running completely.

Here, I would rather label this --ignore-codes, --ignore-messages or simply --ignore

@ernilambar ernilambar changed the title Introduce --exclude-codes in CLI Introduce --ignore-codes in CLI Jan 17, 2025
@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature WP-CLI Issues related to WP-CLI labels Jan 17, 2025
@ernilambar ernilambar added this to the 1.4.0 milestone Jan 17, 2025
@swissspidy swissspidy requested a review from felixarntz January 17, 2025 08:13
swissspidy
swissspidy approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic OK, but still not 100% happy with the name. Curious what others think.

@davidperezgar
Copy link
Member

I'm not sure if it's an standard, but I'd vote for ignore-codes. I think it's fine.

felixarntz
felixarntz approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ernilambar ernilambar merged commit c0d3801 into trunk Jan 17, 2025
29 checks passed
@ernilambar ernilambar deleted the 769-exclude-codes branch January 17, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidperezgar davidperezgar davidperezgar approved these changes

@felixarntz felixarntz felixarntz approved these changes

@swissspidy swissspidy swissspidy approved these changes

@frantorres frantorres Awaiting requested review from frantorres

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27

Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement of an existing feature WP-CLI Issues related to WP-CLI
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Introduce mechanism to exclude certain error codes only
4 participants
@ernilambar @swissspidy @davidperezgar @felixarntz