Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Version Utils in readme check #855

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Jan 13, 2025

  • Removed get_wordpress_stable_version() private helper method from Plugin_Readme_Check in favor of Version_Utils.
  • Version helpers are now consolidated and Version_Utils trait will be responsible for fetching necessary version info details.
  • Updated PHP unit test for the changes

@ernilambar ernilambar marked this pull request as ready for review January 13, 2025 10:15
Copy link

github-actions bot commented Jan 13, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar requested a review from swissspidy January 13, 2025 10:16
@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Jan 13, 2025
@ernilambar ernilambar added this to the 1.4.0 milestone Jan 13, 2025
@davidperezgar davidperezgar merged commit 77f2b8a into trunk Jan 13, 2025
29 checks passed
@davidperezgar davidperezgar deleted the version-utils-readme-check branch January 13, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants