Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for plugin_header_invalid_requires_wp code #827

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Dec 11, 2024

Command: wp plugin check pc-sample --format=csv

Before

FILE: pc-sample.php
code,message
plugin_header_invalid_requires_wp,"The ""Requires at least"" header in the plugin file should only contain a WordPress version such as ""6.5.1"" or ""6.6""."

After

FILE: pc-sample.php
code,message
plugin_header_invalid_requires_wp,"The ""Requires at least"" header in the plugin file should only contain a WordPress version such as ""6.7"" or ""6.6""."

Version here corresponds to the latest WP version and earlier WP version. Earlier those were hardcoded.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Dec 11, 2024
@ernilambar ernilambar added this to the 1.4.0 milestone Dec 11, 2024
@ernilambar ernilambar marked this pull request as ready for review December 11, 2024 06:41
Copy link

github-actions bot commented Dec 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar davidperezgar merged commit d3fbbf6 into trunk Dec 12, 2024
25 checks passed
@davidperezgar davidperezgar deleted the update-requires-wp-header-message branch December 12, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants