Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disallowed domains for Plugin URI check #811

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

ernilambar
Copy link
Member

Fixes #771

  • Update message for plugin_header_invalid_plugin_uri_domain check

Example output:

The "Plugin URI" header in the plugin file is not valid. Discouraged domain "example.com" found. This is the home page of the plugin, which should be a unique URL, preferably on your own website.

@ernilambar ernilambar marked this pull request as ready for review November 27, 2024 06:46
@ernilambar ernilambar changed the title Improve message for Invalid Plugin URI Domain Improve message for invalid Plugin URI domain Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: frantorres <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: dartiss <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Nov 27, 2024
@ernilambar ernilambar added this to the 1.3.0 milestone Nov 27, 2024
@dartiss
Copy link

dartiss commented Nov 27, 2024

Huh. Not sure how my wp.org account became detached from Github. Now fixed though.

@davidperezgar davidperezgar modified the milestones: 1.3.0, 1.4.0 Nov 28, 2024
@ernilambar ernilambar changed the title Improve message for invalid Plugin URI domain Update disallowed domains for Plugin URI check Nov 29, 2024
@ernilambar ernilambar modified the milestones: 1.4.0, 1.3.0 Nov 29, 2024
@ernilambar ernilambar merged commit 3488cb0 into trunk Nov 29, 2024
26 checks passed
@ernilambar ernilambar deleted the 771-the-plugin-uri-header branch November 29, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Plugin URI" header in the plugin file is not valid... except it is
5 participants