Make Requires Plugins header check stricter #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernilambar
force-pushed
the
806-make-plugin_header_invalid_requires_plugins-an-error
branch
from
45fb203 to
9bc5cf1
Compare
ernilambar
requested review from
barrykooij,
davidperezgar,
frantorres and
chriscct7
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ernilambar
added
[Type] Enhancement
ernilambar
commented
Nov 26, 2024
| @@ -4,7 +4,7 @@ | |||
| * Plugin URI: https://github.com/WordPress/plugin-check | |||
| * Description: Test plugin for the Localhost check. | |||
| * Requires at least: 6.0 | |||
| * Requires PHP: 5.6 | |||
| * Requires PHP: latest | |||
There was a problem hiding this comment.
We have one test where we check for lack of error plugin_header_invalid_requires_plugins. This change has been done so that there is errors in $errors variable in the test and our targeted code is not there.
davidperezgar
approved these changes
Nov 26, 2024
swissspidy
approved these changes
Nov 26, 2024
swissspidy
deleted the
806-make-plugin_header_invalid_requires_plugins-an-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #806