Update check for Contributors in markdown readme
#752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernilambar
force-pushed
the
update-contributors-check
branch
3 times, most recently
from
b3b1867 to
75fd748
Compare
ernilambar
force-pushed
the
update-contributors-check
branch
from
75fd748 to
d275c99
Compare
ernilambar
changed the title
Contributors in markdown readme
ernilambar
requested review from
barrykooij,
davidperezgar,
frantorres and
chriscct7
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Great catch! |
davidperezgar
approved these changes
Oct 28, 2024
ernilambar
added
[Type] Bug
ernilambar
force-pushed
the
update-contributors-check
branch
from
9c8f12f to
37f7981
Compare
swissspidy
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #753
Current check (check_for_contributors()) does not work properly when readme is in markdown.
Eg:
Regex is updated to accommodate this format.