CLI: add option to exclude directories #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Enhancement
swissspidy
requested review from
adamsilverstein,
felixarntz and
mukeshpanchal27
swissspidy
added a commit
to WordPress/plugin-check-action
that referenced
this pull request
Oct 31, 2023
mukeshpanchal27
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Thanks @swissspidy for the PR. Could you please update doc for --checks args?
Only runs checks provided as an argument in comma-separated values, e.g. enqueued-scripts, escaping. Otherwise runs all checks.
Should be
Only runs checks provided as an argument in comma-separated values, e.g. i18n_usage, late_escaping. Otherwise runs all checks.
| * ## EXAMPLES | ||
| * | ||
| * wp plugin check akismet | ||
| * wp plugin check akismet --checks=escaping | ||
| * wp plugin check akismet --checks=late_escaping |
Done, thanks! |
18 tasks
felixarntz
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Thanks @swissspidy, LGTM!
We should also enable that in the UI, as it shouldn't only be possible via CLI. Can you open a follow up issue to log that so that we can implement that separately?
|
Done: #313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully tested with
wp plugin check wordpress-seo --exclude-directories=vendor_prefixed,adminFixes #309
Fixes WordPress/plugin-check-action#7