Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin deploy workflow for trunk #306

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Plugin deploy workflow for trunk #306

merged 2 commits into from
Oct 26, 2023

Conversation

mukeshpanchal27
Copy link
Member

Closes #302

Checklist:

@mukeshpanchal27 mukeshpanchal27 changed the title Fix/302 plugin deploy Plugin deploy workflow for trunk Oct 25, 2023
Comment on lines +23 to +24
#SVN_USERNAME: ${{ secrets.SVN_USERNAME }}
#SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For added security, I've commented out the secrets. Once the pull request is ready to be merged, I will remove the comments.

@mukeshpanchal27 mukeshpanchal27 self-assigned this Oct 25, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review October 25, 2023 09:09
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

@felixarntz felixarntz merged commit 38c1559 into trunk Oct 26, 2023
@felixarntz felixarntz deleted the fix/302-plugin-deploy branch October 26, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement plugin deploy workflow in trunk
3 participants