Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for whether speculation rules are printed and default to not when user is logged-in non-admin or PHP session is active #1178

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Add filter for whether speculation rules are printed and default to not when user is logged-in non-admin or PHP session is active #1178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions plugins/speculation-rules/hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,32 @@ function plsr_print_speculation_rules() {
return;
}

/**
* Filters whether speculation rules are printed to the page.
*
* Speculative loading can add excessive server load on sites where many users are logged-in since page caching
* is typically bypassed. So only enable if the user is not logged-in, except if the user is an administrator so
* the can actually see the plugin working. Similarly, when PHP sessions are used, concurrent requests are not
* possible. So if a page takes 2 seconds to generate, and two pages are requested at about the same time, the
* first page's generation will block the generation of the second page, causing the second page to take 4 seconds
* to generate. Therefore, speculation rules are disabled by default when a session is active.
*
* @since n.e.x.t
*
* @param bool $can_print Whether to print speculation rules.
*/
$can_print = (bool) apply_filters(
'plsr_can_print_speculation_rules',
(
( ! is_user_logged_in() || current_user_can( 'activate_plugins' ) )
&&
session_status() !== PHP_SESSION_ACTIVE
)
);
if ( ! $can_print ) {
return;
}

// This workaround is needed for WP 6.4. See <https://core.trac.wordpress.org/ticket/60320>.
$needs_html5_workaround = (
! current_theme_supports( 'html5', 'script' ) &&
Expand Down
Loading