Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Empty last List Element should not be displayed #66344

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

nani-samireddy
Copy link

What?

As mentioned in the above issue. When we create a list and if we leave the last item empty. It renders a empty list item on the front-end.

Why?

It is missing a check while saving the list-item.

How?

  • Added a check to only save the list-item only if it content

Testing Instructions

  • Open the Gutenberg Editor.
  • Add the list block
  • Add two or three items and for the last item keep it empty
  • On the front-end it should not display the last list-item ( empty one)

Testing Instructions for Keyboard

Screenshots or screencast

before

Screenshot 2024-10-22 at 11 21 09 PM Screenshot 2024-10-22 at 11 20 59 PM

After

Screenshot 2024-10-22 at 11 17 20 PM Screenshot 2024-10-22 at 11 17 39 PM

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: nani-samireddy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 22, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @nani-samireddy! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@nani-samireddy nani-samireddy changed the title Add check for empty list item Fix : Empty last List Element should not be displayed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant