Adds Ini_set documentation #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
requested changes
Jun 23, 2019
GaryJones
requested changes
Jun 25, 2019
dingo-d
approved these changes
Aug 1, 2019
jrfnl
reviewed
Nov 6, 2019
There was a problem hiding this comment.
Hi @NielsdeBlaauw I noticed you'd updated this one. Nearly there. I've just left some textual suggestions. Everything else looks A-OK.
Co-Authored-By: Juliette <[email protected]>
|
Completely agree with your suggestions, as these make the desired behaviour much clearer 👍 |
jrfnl
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
@NielsdeBlaauw Thanks for working with us to get this one merge-ready. Great work again.
lesterchan
added a commit
to lesterchan/WordPress-Coding-Standards
that referenced
this pull request
Jan 16, 2020
* upstream/develop: (241 commits) Fix off-by-one error when $treat_files_as_scoped is true Travis: test against PHP 7.4, not snapshot NoSilencedErrors: improve consistency metrics CommaAfterArrayItem: add metrics for comma after last item Travis: don't allow PHP 7.4 build to fail ControlStructureSpacing: fix undefined index error Changelog for WPCS 2.2.0 Adds documentation for WordPress.WP.EnqueuedResources. Various minor documentation fixes Ini_set: add documentation (WordPress#1730) Adds WP.Security.SafeRedirect documentation. Docs: Add PostsPerPage XML doc ✨ New NamingConventions.ValidPostTypeSlug sniff Adds documentation for WordPress.WP.CronInterval Update default minimum supported WP version PrefixAllGlobals: minor efficiency tweak ValidHookName: improve error messages ✨ New DateTime.CurrentTimeTimestamp sniff EscapeOutput: allow for typical pattern with `_deprecated_file()` New "DateTime.RestrictedFunctions" sniff ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1722