Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wootric Crashes #21

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions android/.idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 44 additions & 2 deletions android/src/main/java/com/reactlibrary/RNWootricModule.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package com.reactlibrary;

import android.app.Activity;
import android.util.Log;

import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
Expand Down Expand Up @@ -54,66 +57,105 @@ public String getName() {

@ReactMethod
public void configureWithClientID(String clientId, String accountToken) {
wootric = Wootric.init(getCurrentActivity(), clientId, accountToken);
Activity currentActivity = getCurrentActivity();

if (currentActivity == null) {
Log.e("WOOTRIC", "Current activity is null");
return;
}

try {
wootric = Wootric.init(currentActivity, clientId, accountToken);
} catch (Exception e) {
Log.e("WOOTRIC", e.toString());
}
}

@ReactMethod
public void setEndUserEmail(String email) {
if (wootric == null) return;

wootric.setEndUserEmail(email);
}

@ReactMethod
public void setSurveyImmediately(boolean surveyImmediately) {
if (wootric == null) return;

wootric.setSurveyImmediately(surveyImmediately);
}

@ReactMethod
public void setEndUserCreatedAt(double createdAt) {
if (wootric == null) return;

wootric.setEndUserCreatedAt((long) createdAt);
}

@ReactMethod
public void setEndUserExternalId(String externalId) {
if (wootric == null) return;

wootric.setEndUserExternalId(externalId);
}

@ReactMethod
public void setEndUserPhoneNumber(String phoneNumber) {
if (wootric == null) return;

wootric.setEndUserPhoneNumber(phoneNumber);
}

@ReactMethod
public void setEndUserProperties(ReadableMap properties) {
if (wootric == null) return;

wootric.setProperties(toHashMap(properties));
}

@ReactMethod
public void showOptOut(boolean flag) {
if (wootric == null) return;

wootric.setShowOptOut(flag);
}

@ReactMethod
public void setFirstSurveyAfter(int value) {
if (wootric == null) return;

wootric.setFirstSurveyDelay(value);
}

@ReactMethod
public void setCustomLanguage(String language) {
if (wootric == null) return;

wootric.setLanguageCode(language);
}

@ReactMethod
public void setCustomProductName(String productName) {
if (wootric == null) return;

wootric.setProductName(productName);
}

@ReactMethod
public void setCustomAudience(String audience) {
if (wootric == null) return;

wootric.setRecommendTarget(audience);
}

@ReactMethod
public void showSurvey() {
wootric.survey();
if (wootric == null) return;

try {
wootric.survey();
} catch (Exception e) {
Log.e("WOOTRIC", e.toString());
}
}
}
18 changes: 12 additions & 6 deletions android/src/main/java/com/reactlibrary/RNWootricPackage.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,27 @@
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.uimanager.ViewManager;

import java.util.Arrays;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

public class RNWootricPackage implements ReactPackage {
@Override
public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
return Arrays.<NativeModule>asList(new RNWootricModule(reactContext));
}

// Deprecated from RN 0.47
public List<Class<? extends JavaScriptModule>> createJSModules() {
return Collections.emptyList();
}

@Override
public List<NativeModule> createNativeModules(
ReactApplicationContext reactContext) {
List<NativeModule> modules = new ArrayList<>();

modules.add(new RNWootricModule(reactContext));

return modules;
}


@Override
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
return Collections.emptyList();
Expand Down