Don't restrict VirtualKey mode to Windows only #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sainan
force-pushed
the
vk-for-all
branch
2 times, most recently
from
2f1ef6b
to
d93ee50
Compare
|
Nice suggestion. I have observed that as well, VK is a popular choice as the basis for keycode mappings, so having that more available would be great 😁 |
simon-wh
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this no longer uses any Windows-specific APIs, should be fine to allow it. It's a bit niche, but I know some game engines use VKs as the basis for their internal keycode mappings.