Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: dependency upgrades and dependency instructions update #38

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

build: dependency upgrades and dependency instructions update #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ This section is only relevant if you wish to help develop/contribute code to the
### Dependencies

- [yarn](https://yarnpkg.com/getting-started/install) Is our preferred Node package manager
- [Rust & Tauri](https://tauri.studio/docs/getting-started/intro#setting-up-your-environment)
- [Rust & Tauri](https://tauri.app/v1/guides/getting-started/prerequisites/)

#### Linux

Expand Down
44 changes: 23 additions & 21 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,29 @@
"license": "MIT",
"private": true,
"dependencies": {
"@chakra-ui/icons": "^1.0.12",
"@chakra-ui/react": "^1.6.0",
"@emotion/react": "^11",
"@emotion/styled": "^11",
"@tauri-apps/api": "^1.0.2",
"@tauri-apps/cli": "^1.0.5",
"@testing-library/jest-dom": "^4.2.4",
"@testing-library/react": "^9.3.2",
"@testing-library/user-event": "^7.1.2",
"@types/jest": "^24.0.0",
"@types/node": "^12.0.0",
"@types/react": "^16.9.0",
"@types/react-dom": "^16.9.0",
"core-js": "^3.4.4",
"framer-motion": "^4",
"@chakra-ui/icons": "^2.1.1",
"@chakra-ui/react": "^2.8.1",
"@emotion/react": "^11.11.1",
"@emotion/styled": "^11.11.0",
"@tauri-apps/api": "^1.5.1",
"@tauri-apps/cli": "^1.5.5",
"@testing-library/jest-dom": "^6.1.4",
"@testing-library/react": "^14.0.0",
"@testing-library/user-event": "^14.5.1",
"@types/jest": "^29.5.6",
"@types/node": "^20.8.7",
"@types/react": "^18.2.31",
"@types/react-dom": "^18.2.14",
"core-js": "^3.33.1",
"framer-motion": "^10.16.4",
"lodash": "^4.17.21",
"react": "16.13.1",
"react-dom": "16.13.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-piano": "^3.1.3",
"react-scripts": "^4.0.3",
"react-scripts": "^5.0.1",
"tauri": "^0.15.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "tauri" dependency should not be included here, it's an alpha channel of the "@tauri-apps/cli" that is already included, and the alpha seems to have been abandoned some 9 months ago by now and so is out of date in addition to not being needed.

Copy link
Author

@nathanross nathanross Apr 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right - thanks, and sorry for the long time it took to reply.

"typescript": "^4.8",
"use-context-selector": "^1.1.3"
"use-context-selector": "^1.4.1"
},
"scripts": {
"start": "craco start",
Expand Down Expand Up @@ -56,7 +57,8 @@
]
},
"devDependencies": {
"@craco/craco": "6.4",
"@types/lodash": "^4.14.157"
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@craco/craco": "^7.1.0",
"@types/lodash": "^4.14.200"
}
}
4 changes: 1 addition & 3 deletions src/components/MIDIStateDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,10 @@ const KeyNoteVelocityVisualise = React.memo(
<p>Value</p>
<>
<chakra.label
index={1}
noChildren={entry.notes?.length ?? 0}
gridRow={`2 / span ${(entry.notes?.length ?? 0) + 1}`}
htmlFor={key}
>
{HIDCodes[parseInt(key)]}
{entry.notes?.length ?? HIDCodes[parseInt(key)]}
</chakra.label>
Comment on lines -45 to 49
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't make much sense to me, it doesn't really seem equivalent?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon-wh you're right, it doesn't make any sense. Sorry for the long absence - in my defense I became a father a few months ago. I'll rework this PR next weekend.

<div />
<Box
Expand Down
1 change: 0 additions & 1 deletion src/components/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export function Settings() {
<Text>Velocity Scale</Text>

<NumberInput
type="number"
value={appSettings.note_config.velocity_scale}
onChange={(_, value) => {
if (!isNaN(value) && value !== appSettings.shift_amount) {
Expand Down
Loading