Improve the eTag handling of file downloads

WoltLab · May 25, 2024 · 588d2a1 · 588d2a1
1 parent e8dfe19
commit 588d2a1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/wcfsetup/install/files/lib/action/FileDownloadAction.class.php b/wcfsetup/install/files/lib/action/FileDownloadAction.class.php
@@ -97,26 +97,21 @@ public function handle(ServerRequestInterface $request): ResponseInterface
         }
 
         $eTag = \sprintf(
-            '"W/%d-%s"',
-            $file->fileID,
-            \substr($file->fileHash, 0, 8),
-        );
-        $nonWeakETag =  \sprintf(
             '"%d-%s"',
             $file->fileID,
             \substr($file->fileHash, 0, 8),
         );
 
         $httpIfNoneMatch = \array_map(
-            static fn ($tag) => \preg_replace('~^"W/~', '"', $tag),
+            static fn ($tag) => \preg_replace('~^W/~', '', $tag),
             Header::splitList($request->getHeaderLine('if-none-match'))
         );
-        if (\in_array($nonWeakETag, $httpIfNoneMatch, true)) {
+        if (\in_array($eTag, $httpIfNoneMatch, true)) {
             $emptyResponse = new EmptyResponse(304);
-            if ($response->getHeader('expires')) {
+            if ($response->hasHeader('expires')) {
                 $emptyResponse = $emptyResponse->withHeader('expires', $response->getHeader('expires'));
             }
-            if ($response->getHeader('cache-control')) {
+            if ($response->hasHeader('cache-control')) {
                 $emptyResponse = $emptyResponse->withHeader('cache-control', $response->getHeader('cache-control'));
             }
 

diff --git a/wcfsetup/install/files/lib/system/file/processor/AttachmentFileProcessor.class.php b/wcfsetup/install/files/lib/system/file/processor/AttachmentFileProcessor.class.php
@@ -44,7 +44,7 @@ public function adopt(File $file, array $context): void
     {
         $attachmentHandler = $this->getAttachmentHandlerFromContext($context);
         if ($attachmentHandler === null) {
-            // This can only happen whent he associated object has vanished
+            // This can only happen when the associated object has vanished
             // while the file was being processed. There is nothing we can
             // meaningfully do here.
             return;