close ShrinkWrapClassLoader in test suite (try-with-resources)

WolfgangHG · Dec 4, 2024 · 16728e9 · 16728e9
1 parent 5527e1d
commit 16728e9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/...t/java/org/jboss/arquillian/warp/impl/testutils/TestJavassistAndSeparatedClassLoader.java b/...t/java/org/jboss/arquillian/warp/impl/testutils/TestJavassistAndSeparatedClassLoader.java
@@ -39,10 +39,8 @@ public void test() throws Exception {
 
         JavaArchive archive = ShrinkWrap.create(JavaArchive.class).add(new CtClassAsset(ctClass));
 
-        ShrinkWrapClassLoader classLoader = new ShrinkWrapClassLoader(ClassLoaderUtils.getBootstrapClassLoader(), archive);
-
-        assertNotNull(classLoader.loadClass(CLASS_NAME));
-
-        classLoader.close();
+        try (ShrinkWrapClassLoader classLoader = new ShrinkWrapClassLoader(ClassLoaderUtils.getBootstrapClassLoader(), archive)) {
+            assertNotNull(classLoader.loadClass(CLASS_NAME));
+        }
     }
 }
diff --git a/impl/src/test/java/org/jboss/arquillian/warp/impl/utils/TestShrinkWrapUtils.java b/impl/src/test/java/org/jboss/arquillian/warp/impl/utils/TestShrinkWrapUtils.java
@@ -38,15 +38,14 @@ public void testJavaArchiveFromClass() throws Throwable {
     public void testMultipleUse() throws ClassNotFoundException, IOException {
         JavaArchive archive = ShrinkWrapUtils.getJavaArchiveFromClass(Test.class);
 
-        ShrinkWrapClassLoader classLoader =
-            new ShrinkWrapClassLoader(ClassLoaderUtils.getBootstrapClassLoader(), archive);
-        Class<?> nestedClass = classLoader.loadClass(Test.class.getName());
+        try (ShrinkWrapClassLoader classLoader =
+            new ShrinkWrapClassLoader(ClassLoaderUtils.getBootstrapClassLoader(), archive)) {
+            Class<?> nestedClass = classLoader.loadClass(Test.class.getName());
 
-        JavaArchive nestedArchive = ShrinkWrapUtils.getJavaArchiveFromClass(nestedClass);
+            JavaArchive nestedArchive = ShrinkWrapUtils.getJavaArchiveFromClass(nestedClass);
 
-        assertNotNull(nestedArchive.get("/org/junit/Test.class"));
-        assertNotNull(nestedArchive.get("/org/junit/Ignore.class"));
-
-        classLoader.close();
+            assertNotNull(nestedArchive.get("/org/junit/Test.class"));
+            assertNotNull(nestedArchive.get("/org/junit/Ignore.class"));
+        }
     }
 }