Level code and updated interfaces to accomodate #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Location in the system | ||
| public ILevel Level { get; private set; } | ||
| public IPosition2D Position { get; private set; } | ||
| public IPosition Position |
There was a problem hiding this comment.
Yeah, look better like that
There was a problem hiding this comment.
The only problem is where it's used you will have to cast, but to keep the internals clean it is actually better in my opinion, but when you put samples together we will really know.
|
Look really nice, All those test I want to play with |
|
Updated I think this is ready for the green button now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented the level and the creation of the elements that can go in the level. To do this I had to add a few properties defined in #10 such as Position and SetPosition. I am still not 100% sure that Position rather than Position2D is correct here, however to keep the interfaces generic it is required.
The level implementation has ILevel, ICreateAreas, ICreateTiles, ICreateEntities on it, and takes the creation factories in the constructor. I have left a default constructor so that this can be used as a base class. I think some of these functions could become virtual in that case, but for the moment I have left them as standard functions.
I did think about having the Add for the Level, Area, and Tile set the parent however I think this could be problematic though in some instances.
I have left the position and GetNeighbours to be implemented and I will add an issue to fix this in another PR
What Changed
New Tests!