-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to define different widget layouts for different screen sizes #545
Open
oxixes
wants to merge
30
commits into
Wirecloud:develop
Choose a base branch
from
oxixes:screen-sizes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,140
−2,503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be ready, although any further testing is highly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allows to define different widget configurations for different screen sizes, so that a phone can have a different view than a PC. You can define the boundaries in the workspace configuration, and these can also be different by tab if the user wants to.
Their position and size are adjusted dynamically when the window size changes.
Types of changes
What types of changes does your code introduce to the project: Put an
x
in the boxes that applyChecklist
Further comments
To do this, widgets now store their position for each different screen size. All widgets must have one and only one defined position for every screen size possible, so the boundaries must cover the whole range of possible screen sizes (from 0 to infinity) without gaps or overlaps.
One current limitation is that the layout (column, free, sidebars...) is stored at the widget level, meaning that a widget can only belong to a single layout, and therefore if you change the layout of a widget in one screen size, it will change in every screen size. This limitation can be solved in the future, but this PR is long enough, so it will be part of a different one.
Moreover, all widgets have to be visible in every layout configuration, so in the future we could add the ability to hide widgets in a specific screen size, so one could effectively design completely different layouts (with different widgets) for each screen size.