Merge pull request #30 from AY2324S1-CS2103T-F10-4/master

Pull from team repo
WinstonLeonard · Nov 14, 2023 · 03ecfc5 · 03ecfc5
2 parents f311516 + c86812e
commit 03ecfc5
Show file tree

Hide file tree

Showing 16 changed files with 320 additions and 299 deletions.
diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md
diff --git a/docs/UserGuide.md b/docs/UserGuide.md
diff --git a/docs/diagrams/FindSequenceDiagram.puml b/docs/diagrams/FindSequenceDiagram.puml
@@ -53,10 +53,10 @@ activate FindCommand
 
 note right
 predicate:
-the keyword for the prefix n/
+the predicate for the prefix name n/
 
 subject:
-the keyword for the prefix sb/
+the predicate for the prefix subject sb/
 end note
 
 FindCommand --> FindCommandParser : command
@@ -85,7 +85,7 @@ FindCommand -> Model : updateFilteredPersonList(nameSubject)
 activate Model
 deactivate Model
 
-note right
+note left
 nameSubject:
 the predicate of both inputs for keywords n/ and sb/
 end note

diff --git a/docs/images/EditSequenceDiagram.png b/docs/images/EditSequenceDiagram.png
diff --git a/docs/images/FindSequenceDiagram.png b/docs/images/FindSequenceDiagram.png
diff --git a/docs/images/HelpAfter.png b/docs/images/HelpAfter.png
diff --git a/docs/images/RevenueCommandSuccess.png b/docs/images/RevenueCommandSuccess.png
diff --git a/docs/images/deleteAfter.png b/docs/images/deleteAfter.png
diff --git a/docs/images/editAfter.png b/docs/images/editAfter.png
diff --git a/docs/images/findAfter.png b/docs/images/findAfter.png
diff --git a/docs/images/listunpaidexample.png b/docs/images/listunpaidexample.png
diff --git a/docs/images/paidexample.png b/docs/images/paidexample.png
diff --git a/docs/images/unpaidAllexample.png b/docs/images/unpaidAllexample.png
diff --git a/docs/images/unpaidexample.png b/docs/images/unpaidexample.png
diff --git a/docs/team/jovkusuma.md b/docs/team/jovkusuma.md
@@ -4,34 +4,62 @@ title: Armando Jovan Kusuma's Project Portfolio Page
 ---
 
 ### Project: TuitionConnect
+TuitionConnect is a **desktop app** built for tutors and tutoring businesses to simplify the process of
+administration and finance management, optimized for use via a **Command Line Interface** (CLI) while
+still having the benefits of a Graphical User Interface (GUI).
 
-to be added soon
 
-Given below are my contributions to the project.
+**Code contributed:** Click here for [RepoSense Link](https://nus-cs2103-ay2324s1.github.io/tp-dashboard/?search=jovkusuma&sort=groupTitle&sortWithin=title&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=true&checkedFileTypes=docs~functional-code~test-code&since=2023-09-22&tabOpen=true&tabType=authorship&tabAuthor=jovkusuma&tabRepo=AY2324S1-CS2103T-F10-4%2Ftp%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFileTypes=docs~functional-code~test-code&authorshipIsBinaryFileTypeChecked=false&authorshipIsIgnoredFilesChecked=false).
 
-* **New Feature**:
-  * to be added soon.
-
-* **Code contributed**:
-  * https://nus-cs2103-ay2324s1.github.io/tp-dashboard/?search=jovkusuma&breakdown=true
 
-* **Project management**:
-  * to be added soon.
+**Enhancements implemented:**
 
-* **Enhancements to existing features**:
-    * Enhance find command to be able search for names and subjects using partial keywords.
-    * Enhance find command to be able to search for at least one of `name` and `subject`.
-    * Remove `tag` field as it is not needed for our implementation. 
+* Refactored the `add` and `edit` command.
+  * Remove tags as parameter for both `add` and `edit` command.
+  * (Pull Requests [#90](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/90))
 
-* **Documentation**:
-  * User Guide:
-    * Did tweaks to existing documentation for the feature `find` command
-    * Determine the overall structure and format of the user guide.
-  * Developer Guide:
-    * Added use cases for `add` and `delete` of a tutee.
+* Enhance the `find` command
+  * Allow users to find tutees using partial keywords.
+  * Allow users to find by name and/or subject to find for tutees.
+  * (Pull Requests [#68](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/68), [#127](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/127))
 
-* **Community**:
-  * to be added soon.
+* Enforce that `begin` time should strictly be before `end` time.
+  * Restrict users to only input `begin` times which are before `end` times. 
+  * (Pull Requests [#111](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/111))
 
-* **Tools**:
-  * to be added soon.
+* Write and fixing test cases:
+  * Fixed the test cases for `StringUtilTest`, `AddressBookParserTest`, `FindCommandTest`, `FindCommandParserTest`, `NameContainsKeywordsPredicateTest`
+    to support refactored `find` command (Pull Requests [#68](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/68),[#127](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/127)).
+  * Fixed the test cases for `AddCommandTest`, `EditCommandTest` to support the enforcement of begin time less than end time (Pull Requests [#111](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/111)).
+  * Wrote test cases for `SubjectContainsKeywordsPredicateTest`, `NameSubjectPredicateTest`
+    to test the `find` Command (Pull Requests [#127](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/127), [#199](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/199)).
+
+**Contributions to the UG:**
+
+* Added `Using this guide` and `Glossary` sections (Pull Requests [#209](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/209)).
+* Wrote features and descriptions for `help`, `find`, `edit` and `delete` (Pull Requests [#235](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/235)).
+
+
+**Contributions to the DG:**
+
+* Added use cases for `add`, `edit` and `find` commands (Pull Requests [#102](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/102), [#210](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/210)).
+* Added description and sequence diagram for `find` and `edit` commands (Pull Requests [#197](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/197)).
+* Wrote manual test cases for `find` command (Pull requests [#234](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/234)).
+* Wrote planned enhancements (Pull Requests [#210](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/210)).
+
+
+**Contributions to team-based tasks**:
+
+
+* Updating config.yml (Pull Requests [#53](https://github.com/AY2324S1-CS2103T-F10-4/tp/pull/53)).
+
+
+**Review/Mentoring contributions:**
+
+* Reviewed a total of 31 PRs.
+* Reviewed and offered suggestions for team member's pull requests.
+
+
+**Contributions beyond the team project:**
+
+* Assisted other teams and reported 9 bugs during the [Practical Exam Dry Run](https://github.com/jovkusuma/ped/issues).
diff --git a/docs/team/yihfei.md b/docs/team/yihfei.md
@@ -26,6 +26,7 @@ Given below are my contributions to the project.
     * Maintained the team collaboration google docs (e.g. documenting features for v1.3)
     * Renamed the product
     * Created the icon for product
+    * Drafted the mock UI
 
 * **Enhancements to existing features**:
   * Enhanced the GUI (Implement coloured tags for paid indicator, tags for subject, rounded corners for result display and search bar)
@@ -36,8 +37,7 @@ Given below are my contributions to the project.
     * Added and modified documentation for the features `add` , `edit` and `rev` features
     * Updated GUI pictures
   * Developer Guide:
-    * Added implementation details of the `delete` feature.
-
+    * Added implementation details and sequence diagrams of the `add` and `rev` feature.
 
 * **Community**:
     * to be added soon