Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Add a LICENCE to ensure composability and re-use virality #24

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

JFWooten4
Copy link
Member

@JFWooten4 JFWooten4 commented Jan 19, 2025

@tehchives recently added the awesome DRS percent holding leaderboard image code from @jergy2 in e67a074.

I was just glancing over this earlier today in finding pages to share in #23. This was one of my favorite pages, but I didn't experiment with it because I figured it'd have a custom social preview of the actual image.

Anyway, since we're adding content here to decentralize the ongoing public info development, I suppose it'd be prudent to include a license earlier rather than later—so that we don't have to query everyone that's done work in the future like in WhyDRS/Taking-Stock#17.

As long as that sounds good via an OK from Chives and Jersan, then this PR should get that set up for everyone!

@JFWooten4
Copy link
Member Author

Also, James was kind enough to let me know in 808552d that we aren't using some of the default imports from the Wix bot, so I'll add another commit removing these deprecated boilerplate functions.

@JFWooten4 JFWooten4 marked this pull request as ready for review January 19, 2025 01:57
@tehchives
Copy link
Contributor

What you're describing sounds good to me, but I might be missing something basic about Git navigation here. Looking at the PR, the licensing language was already present excepting a [^def] (and what is that?) while most of the changes are removing an example. Curious to know more about the changes you are performing in this PR and their implications if you do not mind! Thank you John for your forward thinking about how we can license these growths mindfully for tomorrow!

@JFWooten4
Copy link
Member Author

JFWooten4 commented Jan 19, 2025

Sure, so I removed some default scripts that we aren't using because those are not created by any of the community members. Accordingly, they would presumably be the proprietary code of Wix or their Velo development team — as they came from the initial import through the site interface. This could be problematic because they were added without any kind of license, so I think the safest bet is to just remove them given we are not using the very minor aspects with them. 💜

As for the [^def], that was just reformatting the README explaining the permissions JSON. I removed a redundant example which duplicates their existing public documentation and migrated a repetitive sentence into the footnote. That's how footnotes work in markdown:

This is my text.[^fn]

[^fn]: Pretty short!

You can try this out in a comment reply if you’d like, and see it when you press Preview. I would prefer to delete the whole file, but you can’t add comments in the relevant permissions file due to its structure, so I figured we could leave the basic info about what it’s doing for now.

So yes, you are right in that a lot of the changes are removing examples, largely because these examples lie in a licensing grey-zone where we don’t know who wrote them, and building on them later could be troublesome. So my implementation opted for maximum safety when introducing our own Affero by ensuring that only the material code we wrote still stands in the repo. That and this one required a very brief permissions security config that ties into the central site for now.

Upon merging, it’d also be great to get this OK’d by Jersan since I understand that they wrote some of the code which is being omitted, which is why I tagged them. I’d say the same for anything else that was developed by the handful of community members with access to the Wix login.

Happy to get it on the table! I went through some Syndicate repos and added a few licenses last night, too — just the kind of thing that is 1000% easier to do at the start to set the ground rules rather than retroactively working around everything later, notifying anyone who helped, and generally offering a lot of clarity for potential open-source contributors who happened to like the repo. All this came to me when my free-markets project got its first star, so I just wanted to make sure this was up to scale given the awesome addition of the custom leaderboard code. Presumably, we can do a whole lot more with this repo than just these (unused) scripts if awesome community members like Jersan keep sharing their custom implementations! 🌌

@tehchives
Copy link
Contributor

Makes a lot more sense! Thank you. Very reasonable to wait for @jergy2 input as well.

@jergy2
Copy link
Contributor

jergy2 commented Jan 22, 2025

If I am understanding the situation correctly then I have no issues whatsoever with proceeding. Please proceed! While I appreciate being included I do not feel that my approval was necessary for proceeding in this case. Let me know if there are any issues and I will assist

@JFWooten4 JFWooten4 merged commit 0a7ab70 into main Jan 27, 2025
@JFWooten4 JFWooten4 deleted the add-open-licence branch January 27, 2025 18:53
@JFWooten4
Copy link
Member Author

Proceeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants