-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsletter support (absorbs #820 and #822) #961
base: master
Are you sure you want to change the base?
Conversation
* initial commit * add reactions support * changes * fix type error * add enableLiveUpdates fn / remove reaction handler in decode * add newsletter functions (to test) * add events / other things * fix handler * add extract metadata * add types * add admin events / some fixes * better typing * typing / add some functions (to test) * add parse for fetchMessages * improve parseFetched / typing * finish * lint / fix metadata * better newsletter socket structure * fix / add tos query in newsletterCreate --------- Co-authored-by: Rajeh Taher <[email protected]>
Thanks for your contribution. The next step is to wait for review and approval to merge it to main repository The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it. To test this PR you can run the following command below:
|
As I can see it doesn't support sending media yet right? |
Raw media uploads to be added soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it will merge
Is there any update for this feature? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing from this PR:
- Full linting coverage
- proper storage of newsletter information (? not sure if it is needed)
- Raw media uploads
No description provided.