Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: updated twitter icon new x icon #540

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

SudeeptaGiri
Copy link
Contributor

@SudeeptaGiri SudeeptaGiri commented Oct 24, 2023

Related Issue

  • As Twitter logo is changed we need to change twitter logo now in our website

Closes: #525

Describe the changes you've made

changed the Old Twitter Logo to new X Logo
I just added the SVG path of X
It is working fine for both Dark mode and Light Mode

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

I have run the code in My System in the Microsoft Edge Browser and in the FireFox Browser too and it is working fine

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
Screenshot 2023-10-24 110930 Screenshot 2023-10-24 110910

Code of Conduct

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 5:41am

@SudeeptaGiri SudeeptaGiri changed the title Issue#525 fix: Updated Twitter Icon new X Icon Oct 24, 2023
@SudeeptaGiri SudeeptaGiri changed the title fix: Updated Twitter Icon new X Icon fix: updated twitter icon new x icon Oct 24, 2023
@SudeeptaGiri SudeeptaGiri changed the title fix: updated twitter icon new x icon bug: updated twitter icon new x icon Oct 24, 2023
Copy link
Member

@s2sharpit s2sharpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, Congrats on your first commit @SudeeptaGiri.

Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@s2sharpit
Copy link
Member

It looks great to me. I'm merging this PR.

@s2sharpit s2sharpit merged commit 776529e into WebXDAO:main Oct 24, 2023
3 of 4 checks passed
@SudeeptaGiri
Copy link
Contributor Author

SudeeptaGiri commented Oct 25, 2023

Thank You @s2sharpit & @vinzvinci :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER]: Want to chage Twitter logo
3 participants