Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move incoming value ownership on consumption #21

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix: move incoming value ownership on consumption #21

merged 1 commit into from
Mar 18, 2024

Conversation

rvolosatovs
Copy link
Contributor

Move ownership of incoming-value on consumption, this is the same as WebAssembly/wasi-keyvalue#39

thomastaylor312
thomastaylor312 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix here @rvolosatovs

@thomastaylor312
Copy link
Collaborator

Given that this change is identical to what happened in keyvalue, I am going to go ahead and merge

@thomastaylor312 thomastaylor312 merged commit 6387153 into WebAssembly:main Mar 18, 2024
1 check passed
@rvolosatovs rvolosatovs deleted the fix/incoming-value-ownership branch March 18, 2024 19:57
@rvolosatovs rvolosatovs mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvolosatovs @thomastaylor312