Add spec tests for the custom-page-sizes proposal #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were written while implementing the proposal in Wasmtime: bytecodealliance/wasmtime#8763
|
@rossberg or @conrad-watt, is there an easy way to mark certain spec tests as ignored by the spec interpreter temporarily so that CI doesn't fail indefinitely until I implement this proposal for the spec interpreter? I didn't find anything in |
|
I don't think we currently have a means of turning off individual tests. The easiest thing you can do right now is just commenting out the entire test step in the GH workflow for the interpreter. |
|
@rossberg makes sense, thanks! |
They can be re-enabled once the spec interpreter gains support for the custom-page-sizes proposal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were written while implementing the proposal in Wasmtime: bytecodealliance/wasmtime#8763