Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dependabot updates to Poetry, fix tests and docs build #6

Merged
merged 14 commits into from
Oct 30, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Oct 26, 2024

This PR focuses on long-term sustainability for this project by enabling Dependabot to automatically update the Poetry lockfile. Normally this is a task which must be performed manually. By enabling this change we can have Dependabot automatically update the dependency references (which still fall into the constraints of the pyproject.toml file).

Thanks for any feedback!

Should be merged after #4

Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excited to see the progress of this work!

@d33bs
Copy link
Member Author

d33bs commented Oct 30, 2024

Thanks @jenna-tomkinson for the review here! I'm going to interpret your review as an approval for #4, as it goes through code which this branch was based on. I'll merge #4 and then this PR to keep the git history clean and descriptive. Related issues were created or referenced to help make sure we address what you mentioned in the comments.

@d33bs d33bs marked this pull request as ready for review October 30, 2024 20:35
@d33bs d33bs changed the title Enable Dependabot updates to Poetry lockfile Enable Dependabot updates to Poetry, fix tests and docs build Oct 30, 2024
@d33bs
Copy link
Member Author

d33bs commented Oct 30, 2024

Added changes which are more related to #4 which weren't apparent until after a merge (automated tests were prevented and a docs build failed after merge). I'm trying to keep things succinct by appending the changes here.

@d33bs d33bs merged commit c35b06c into WayScience:main Oct 30, 2024
9 checks passed
@d33bs d33bs deleted the dependabot-poetry-lock branch October 30, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants