Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read outlines or masks from segmentation_file_regex parameter #25

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Nov 11, 2024

Description

This PR adds a new parameter to CytoDataFrame: segmentation_file_regex. This parameter assists users in associating masks or outline files with original images where they may otherwise have different naming conventions. When segmentation_file_regex is None we fall back to the original capability, gracefully seeking files which match the original filenames.

Thanks for any feedback!

Closes #22

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d33bs d33bs marked this pull request as ready for review November 11, 2024 22:37
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have a minor comment about how the new ALSF example looks and that some of the other examples look a bit funky. Maybe we can talk in person about it! Other than that, code looks pretty sound to me!

@d33bs
Copy link
Member Author

d33bs commented Nov 12, 2024

Thanks @jenna-tomkinson ! I created #28 to help address the image darkness issue and plan to meet up with you to discuss more.

@d33bs d33bs merged commit e3e3962 into WayScience:main Nov 12, 2024
9 checks passed
@d33bs d33bs deleted the alsf-test-data-and-new-param branch November 12, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test and new capabilities for ALSF project
2 participants