Chushogi: Fix bug with non-lion double movers capturing lion #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue: WandererXII/lishogi#830
It was discovered that when a non-Lion double mover captures a Lion on the mid step and then moves to another square (igui or hit and run), the last lion capture square used for counterstrike protection rules was not being set. Several highly skilled/professional players confirmed that this is a bug, and that the eagle/falcon should set this square despite having made the capture with a "Lion move".
My changes here allow for the Lion capture square to be set off of a mid step capture, not just a final square capture.
Specifically:
secondCapture
tomidCapture
, which is more correctmidCapture
first, since it happens before thecapture
at the final squareCheers, and please let me know if anything with my PR needs adjustments (such as changelog/versioning things).