Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destroying receivers #33

Merged
merged 2 commits into from
Jul 14, 2024
Merged

Fix destroying receivers #33

merged 2 commits into from
Jul 14, 2024

Conversation

kmod-midori
Copy link
Contributor

@kmod-midori kmod-midori commented Jul 12, 2024

Fix #32.
delete receivers will actually leave them running in the background.

Copy link
Owner

@WalkerKnapp WalkerKnapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for catching this and contributing!

@WalkerKnapp
Copy link
Owner

I'll merge after fixing the actions.

@kmod-midori
Copy link
Contributor Author

You probably need to throw echo yes after sudo like sudo 'echo y | ....', as sudo does not like being piped into (even though the actions environment does not require password).

@WalkerKnapp
Copy link
Owner

So sorry for the delay! You were right, but it seems like a bunch has changed in addition to that since I last touched the CI. The CI failure now is just because it doesn't have access to secrets, it looks like the actual build completed just fine :)

(gradle is so unimaginably painful to debug)

@WalkerKnapp WalkerKnapp merged commit 090ce70 into WalkerKnapp:dev Jul 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants