-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync v1.2.2 changes to main branch #487
Open
kadamwhite
wants to merge
12
commits into
master
Choose a base branch
from
v1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes since v1.1.2: - **BREAKING**: The minimum supported node version is now v8. - **BREAKING**: `._paging.total` and `._paging.totalPages` response properties are now returned as integers, not strings. - Bundled route handlers are now available for new first-party endpoints in WordPress 5.0. - The project now uses Jest and ESLint in place of Mocha, Chai, JSCS and JSHint. Thank you for your years of service, ["nyan" reporter](https://mochajs.org/#nyan)! - Browser bundle size has been reduced. Props @computamike.
…g a buffer (#418) Fixes #344 props @cungminh2710, @mvhirsch
@HoraceShmorace rightly comments that we have not made our conformance to semver (or lack thereof) clear, and the Node support matrix change in 1.2 constitutes an insufficiently-announced breaking change. This commit updates the README and CHANGELOG to clarify that this library will only run correctly on Node versions later than 8.2.1 `--harmony`, not simply any version of Node v8. Closes #419
- Fix route match error with WordPress 5.5 - Throw an error early when .file() is passed a Buffer without an accompanying name string Props @socrates77, @cungminh2710 & @mvhirsch
jojonarte
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.