-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spec] Enable per-context contribution limits for Private Aggregation #216
base: main
Are you sure you want to change the base?
Conversation
@alexmturner and @pythagoraskitty, PTAL! |
@xyaoinum, PTAL as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Dan! LGTM % one comment (and maybe makes sense to wait for the PAA PR to land to avoid the "ignore")
The goal is to enable Shared Storage embedders to override the default number of contributions per Private Aggregation report. To that end, this change adds the `maxContributions` field to the web-visible Private Aggregation config dictionary and plumbs its value into Private Aggregation's "pre-specified report parameters". Context: * Explainer: patcg-individual-drafts/private-aggregation-api#146 * Spec change: patcg-individual-drafts/private-aggregation-api#164
00dc367
to
e98524b
Compare
Done! @xyaoinum PTAL :) |
@jkarlin PTAL if you have time :) |
The goal is to enable Shared Storage embedders to override the default number of contributions per Private Aggregation report.
To that end, this change adds the
maxContributions
field to the web-visible Private Aggregation config dictionary and plumbs its value into Private Aggregation's "pre-specified report parameters".Context:
Preview | Diff