Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec] Enable per-context contribution limits for Private Aggregation #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmcardle
Copy link
Contributor

@dmcardle dmcardle commented Jan 9, 2025

The goal is to enable Shared Storage embedders to override the default number of contributions per Private Aggregation report.

To that end, this change adds the maxContributions field to the web-visible Private Aggregation config dictionary and plumbs its value into Private Aggregation's "pre-specified report parameters".

Context:


Preview | Diff

@dmcardle
Copy link
Contributor Author

dmcardle commented Jan 9, 2025

@alexmturner and @pythagoraskitty, PTAL!

@dmcardle dmcardle marked this pull request as ready for review January 9, 2025 22:13
@dmcardle
Copy link
Contributor Author

dmcardle commented Jan 9, 2025

@xyaoinum, PTAL as well.

Copy link
Collaborator

@alexmturner alexmturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dan! LGTM % one comment (and maybe makes sense to wait for the PAA PR to land to avoid the "ignore")

spec.bs Outdated Show resolved Hide resolved
The goal is to enable Shared Storage embedders to override the default
number of contributions per Private Aggregation report.

To that end, this change adds the `maxContributions` field to the
web-visible Private Aggregation config dictionary and plumbs its value
into Private Aggregation's "pre-specified report parameters".

Context:
* Explainer: patcg-individual-drafts/private-aggregation-api#146
* Spec change: patcg-individual-drafts/private-aggregation-api#164
@dmcardle dmcardle force-pushed the add-max-contributions branch from 00dc367 to e98524b Compare January 16, 2025 16:28
@dmcardle
Copy link
Contributor Author

Thanks, Dan! LGTM % one comment (and maybe makes sense to wait for the PAA PR to land to avoid the "ignore")

Done!

@xyaoinum PTAL :)

@dmcardle
Copy link
Contributor Author

@jkarlin PTAL if you have time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants