fix: Tolerate multiple imports/loads of the script #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may come up that multiple scripts import or load the polyfill into the same document. In such cases we want to ensure the polyfill only runs once.
maranomynet
commented
Nov 5, 2020
Comment on lines
-298
to
-300
| } | ||
|
|
||
| if (typeof document !== 'undefined') { |
There was a problem hiding this comment.
I'm assuming these conditional blocks can be safely joined, for simplicity+brevity
| @@ -276,7 +276,7 @@ function applyFocusVisiblePolyfill(scope) { | |||
| // It is important to wrap all references to global window and document in | |||
| // these checks to support server-side rendering use cases | |||
| // @see https://github.com/WICG/focus-visible/issues/199 | |||
| if (typeof window !== 'undefined' && typeof document !== 'undefined') { | |||
| if (typeof window !== 'undefined' && typeof document !== 'undefined' && !window.applyFocusVisiblePolyfill) { | |||
There was a problem hiding this comment.
Just checking for applyFocusVisiblePolyfill is sufficiently safe as the function is always run right after it's assignment into the global Window scope
|
@maranomynet - can you join the WICG to appease the IPR bots? |
|
I've ventured down that rabbit hole of bad onboarding UX, and emerged mostly unscathed.
|
|
Any chance of seeing this merged? |
|
I can't believe it's been three years already. Time flies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may come up that multiple scripts import or load the polyfill into the same document.
In such cases we want to ensure the polyfill only runs once.