Skip to content

Commit

Permalink
Update index.html
Browse files Browse the repository at this point in the history
  • Loading branch information
@robdodson
robdodson authored Jun 27, 2024
1 parent 9fbee13 commit 78d61ac
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion demo/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ <h2>Other</h2>
<div>
<input type="file" title="File">
</div>
<script src="https://cdn.polyfill.io/v2/polyfill.js?features=Element.prototype.classList"></script>
<script src="https://unpkg.com/focus-visible"></script>
</body>
</html>

8 comments on commit 78d61ac

@offbeat-dev
Copy link

@offbeat-dev offbeat-dev commented on 78d61ac Jun 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @robdodson,
Thank you for removing this reference to cdn.polyfill.io !!
Wanted to ask if there are any plans of generating a new release, even just for this change, so searches for polyfill.io in the node_modules folder don't throw false positives? Just wondering.

Once again, thank you!

@robdodson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's a good idea. I haven't done a release in ages. Let me see I can still remember how... 😅

@offbeat-dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣
sounds great @robdodson! thank you!

@felixranesberger
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Just wanted to bump this up, since I just got a false positive while searching for the polyfill.io string.
Any updates on the release? 🚀

Also: the readme on NPMJS still references the polyfill.io CDN, which while still being offline could become malicious in the future again.

@felixranesberger
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robdodson (sorry for the direct mention, don't know if you would get a notification for a regular comment)

@robdodson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @felixranesberger - I think I'll have to block out some time this weekend to try to do a build. I tried building it on my machine a few weeks back and it didn't work because the dependencies are all so old.

@robdodson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@offbeat-dev @felixranesberger a new version should be up now. Please let me know if y'all encounter any issues.

@offbeat-dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great! thank you @robdodson 🙏

Please sign in to comment.