-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-lingual support #242
base: master
Are you sure you want to change the base?
Multi-lingual support #242
Conversation
…ittle bit tested. A class Translator is added, it stores all the translations for the part names (like string, barrel, etc)
Interesting approach, but one of the reasons we don't use this kind of mechanics is that we want use out of the box translation payloads provided by Warframe.market (you might be able to see it in source draft PR). Is there a reason you don't use same way and instead manually translate the part names? |
I completely understand the problem with my solution. But I wasn't able to reproduce the request to the warfame.market API but in french. For exemple : "https://api.warframestat.us/wfinfo/filtered_items" which is (I believe) the base data set. I will try working on another solution with the data from warframe.market. Could you explain how the custom "wfinfo" request was made ? |
The ReloadItems function takes care of fetching the translation data according to the locale setting (which your change to |
… on warframe market. It is similar to WFCD#231 MasterIt has not been tested. Displays are not translated.
I just pushed another version similar to the one from #231. As I said in the commit message, I did not check either Master It or the translation of the displays. I will work on understanding how Master It works. |
…nch langage. I was'nt able to test it as it does not work at the time of this commit
…ittle bit tested. A class Translator is added, it stores all the translations for the part names (like string, barrel, etc)
…of resources files to translate all hard coded texts. The UI texts are not translated yet. Added a status message to inform the user that the locale has been changed The equiment is redrawn each time it is opened
…displaying the initialization messages from the wrong locale.
Ok ok, some news from here. I had a bit of trouble with git after the release of 9.5.4 The last interesting commits are focused on UX. I also have, at the time when I write this message modified the output texts of the Snap-It to display the local names of the parts. I will refactor it to work for all displays. I think this version is production ready, as long as the users speak a bit of english (UI) but I assume they do if they end up downloading this tool. What do you think ? |
I want it to merge! |
Conflict, sadly. |
I added support for french but tried to do it in a way that it is relatively easy to add other Latin-alphabet-based languages.
It works with a new class Translator, it stores all the translations for the part names (like string, barrel, etc) in a dictionary.
What did you fix?
I tried to fix Multi-Language OCR Support
closes #67
Evidence/screenshot/link to line
Considerations