Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/event off error #1318

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Fix/event off error #1318

merged 3 commits into from
Oct 25, 2023

Conversation

skie1997
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

🔗 Related PR link

🐞 Bugserver case id

6538db6e159a621b655d9fa3

💡 Background and solution

问题:
chart.release() 之后 chart.off(xxxx)报错
img_v2_788daa38-2a9d-4cc0-9cae-6562aec6686g

原因:
release之后,userEvent被置空,导致报错

解决方案:
增加userEvent判空逻辑

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@skie1997 skie1997 requested a review from xiaoluoHe October 25, 2023 09:25
@kkxxkk2019 kkxxkk2019 added this to the v1.5.3 milestone Oct 25, 2023
@skie1997 skie1997 merged commit 0d0c279 into develop Oct 25, 2023
4 of 5 checks passed
@skie1997 skie1997 deleted the fix/event-off-error branch October 25, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants