Skip to content
This repository has been archived by the owner on Oct 11, 2019. It is now read-only.

Export/dev VP-255 use export in do export in pricing #521

Open
wants to merge 22 commits into
base: export/dev
Choose a base branch
from

Conversation

AliveMen
Copy link
Contributor

add PricingFullPagedDataSource
update metadata getters

{
var newExportDataQuery = new T();
newExportDataQuery.Skip = _dataQuery.Skip;
newExportDataQuery.Take = _dataQuery.Take;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need to fill Skip and Take here with source dataQuery values

state.Result = Array.Empty<IExportable>();
if (state.ReceivedCount < state.TotalCount)
{
state.DataQuery.Take = takeNext;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How dataQuery pagination is respected here? If we sent dataQuery.Take and Skip (e.g. dynamic scroll in viewer), they should be respected based on the states TotalCount-s.

@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants