Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pedantic Grammar/Syntax Issues In README.md #947

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

rynstwrt
Copy link

@rynstwrt rynstwrt commented Jan 6, 2025

FIXES:

  • Change "Allows the connection of older clients to..." to "Allows older clients to connect to..."
  • Remove extra period.
  • Change "early-access" to "early access"
  • Change sentence addition after a comma to be a separate sentence.
  • Change "open source" to "open-source"

Sorry 😭 I saw the double period and went to fix it and noticed more stuff.

@FormallyMyles
Copy link
Member

I'd personally say that apart from the extra period and a slight increase in conciseness to the first line, the other changes aren't really needed.

@rynstwrt
Copy link
Author

rynstwrt commented Jan 6, 2025

I feel you. I would say the comma addition part to a new sentence is more necessary than the hyphenation changes but less important than the double period and the concision of the client connection line, Just thought I'd include really small stuff while I was at it :P

Copy link
Member

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the extra review, I agree with myles.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Revert to the original intro text and remove the hyphen from "open source"
README.md Outdated Show resolved Hide resolved
@FlorianMichael FlorianMichael merged commit 624fb6a into ViaVersion:master Jan 7, 2025
1 check passed
@FlorianMichael
Copy link
Member

Thanks :)

@rynstwrt rynstwrt deleted the patch-1 branch January 15, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants