Treat pom scope=runtime as compile to make gradle poms usable #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle's "implementation" configuration for dependencies results in published maven poms that are technically accurate for building bytecode, but useless for building J2CL. To fix this, we interpret any scope=runtime as if it says scope=compile. This patch also tests many publicly released gwt modules to ensure that they build cleanly in the plugin, with the hope of avoiding this issue in the future. There are several commented out dependencies, to avoid trying to build gwt-dom until the next release is ready. Bug Vertispan#127 is filed for followup. Fixes Vertispan#126
niloc132
force-pushed
the
126-gradle-runtime-scope
branch
from
37500ac to
7b17a99
Compare
This wasn't needed locally with a clean maven cache, but apparently GHA wants to have it.
niloc132
force-pushed
the
126-gradle-runtime-scope
branch
from
6079e1b to
0bb2294
Compare
|
Build failure continues to not happen locally even with a custom maven local repo, downloading everything from scratch. I have now managed to reproduce the failure in |
I don't like this "fix", but it does force the invoker plugin to correctly use the dependencies it has downloaded. This PR will be split to avoid merging this with the actual fix
|
Closing for now in favor of #130, the maven-invoker-plugin doesn't seem to be setting up the extraArtifacts correctly such that the integration tests can use them. I'll land the tests separately when I have an acceptable resolution to this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle's "implementation" configuration for dependencies results in
published maven poms that are technically accurate for building
bytecode, but useless for building J2CL. To fix this, we interpret any
scope=runtime as if it says scope=compile.
This patch also tests many publicly released gwt modules to ensure that
they build cleanly in the plugin, with the hope of avoiding this issue
in the future. There are several commented out dependencies, to avoid
trying to build gwt-dom until the next release is ready. Bug #127 is
filed for followup.
Fixes #126