Suppressed ClosedWatchServiceException and updated Java of Archetypes…

… to 11 (#231) Fixes #188 Co-authored-by: Dmitrii Tikhomirov <[email protected]>
Vertispan · Nov 5, 2023 · 52c4d09 · 52c4d09
1 parent 33ce152
commit 52c4d09
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/build-caching/src/main/java/com/vertispan/j2cl/build/DiskCache.java b/build-caching/src/main/java/com/vertispan/j2cl/build/DiskCache.java
@@ -170,6 +170,14 @@ private void checkForWork() {
         } catch (IOException e) {
             // disaster, can't interact with the cache, stop and give up
             // TODO mark all pending work as canceled?
+        } catch (ClosedWatchServiceException e) {
+            if(!livenessThread.getState().equals(Thread.State.TERMINATED)) {
+                 throw new Error(e);
+            }
+
+            // This is purely noise in the log and doesn't indicate an actual
+            // error, so it can be safely ignored. Please see:
+            // https://github.com/Vertispan/j2clmavenplugin/issues/188
         }
     }
 

diff --git a/j2cl-archetypes/pom.xml b/j2cl-archetypes/pom.xml
@@ -16,9 +16,8 @@
   <description>Maven project archetypes for using J2CL</description>
 
   <properties>
-    <!-- Continue defaulting to 1.8 until we have good support for 11 -->
-    <maven.compiler.target>1.8</maven.compiler.target>
-    <maven.compiler.source>1.8</maven.compiler.source>
+    <maven.compiler.target>11</maven.compiler.target>
+    <maven.compiler.source>11</maven.compiler.source>
   </properties>
 
   <build>