-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShowConnections: Cap max number of connections displayed #3156
Open
sadan4
wants to merge
19
commits into
Vendicated:dev
Choose a base branch
from
sadan4:fix/showConnections
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179
−31
Open
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5280819
make
sadan4 bcf1143
change default
sadan4 dea71ae
horrorcode
sadan4 2e51ed2
use string unions and fix some typings
sadan4 024f642
use interfaces
sadan4 8ff1d58
fix types (whoops)
sadan4 4fb6279
own profile will always be there
sadan4 892376b
whoops, theres a third arg :blobcatcozy:
sadan4 aedf4fb
use Clickable
sadan4 0d56c5f
fix icon
sadan4 24affad
use number
sadan4 0a518bc
guh
sadan4 eb251f9
Merge branch 'dev' into fix/showConnections
sadan4 9e38397
remove param and add line
sadan4 b7c55ff
move to settings def
sadan4 b7572b3
Merge branch 'dev' into fix/showConnections
sadan4 6de58a1
fix lint
sadan4 8a561c0
fix lint
sadan4 f8ba981
Merge branch 'dev' into fix/showConnections
sadan4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slider would be better. just do 5-50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a slider doesn't work due to the fact that the size of the icons is customizable, leading to a multiple of seven -1 not always being the ideal number for an even row