Fix log4j version inconsistency (log4j-api and log4j-core versions we…

…re inconsistent, causing "no such method" exception).
Vastra-Gotalandsregionen · Sep 6, 2023 · fcf51c3 · fcf51c3
1 parent 15ac319
commit fcf51c3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/core-bc/composites/svc/src/main/java/se/vgregion/handbok/service/DocumentFetcherService.java b/core-bc/composites/svc/src/main/java/se/vgregion/handbok/service/DocumentFetcherService.java
@@ -47,9 +47,9 @@ public Document[] fetchDocuments(String feedId) throws IOException {
         urlConnection.setConnectTimeout(TIMEOUT);
         urlConnection.setReadTimeout(TIMEOUT);
 
-        InputStream inputStream = urlConnection.getInputStream();
-
-        return JSON_MAPPER.readValue(inputStream, Document[].class);
+        try (InputStream inputStream = urlConnection.getInputStream()) {
+            return JSON_MAPPER.readValue(inputStream, Document[].class);
+        }
     }
 
     public Document[] fetchDocumentsPutCache(String feedId) throws IOException {

diff --git a/pom.xml b/pom.xml
@@ -38,6 +38,7 @@
         <junit.version>4.12</junit.version>
         <liferay.version>7.4.13.u73</liferay.version>
         <slf4j.version>1.7.36</slf4j.version>
+        <log4j.version>2.17.2</log4j.version>
         <portlet-api.version>2.0</portlet-api.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <servlet-api.version>3.0.1</servlet-api.version>
@@ -60,17 +61,17 @@
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-api</artifactId>
-            <version>1.7.36</version>
+            <version>${slf4j.version}</version>
         </dependency>
         <dependency>
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-slf4j-impl</artifactId>
-            <version>2.17.2</version>
+            <version>${log4j.version}</version>
         </dependency>
         <dependency>
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-core</artifactId>
-            <version>2.17.2</version>
+            <version>${log4j.version}</version>
         </dependency>
         <dependency>
             <groupId>junit</groupId>