Solved issue 182 #284
Merged
Solved issue 182 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Saksham2k3s is attempting to deploy a commit to the vansh69's projects Team on Vercel. A member of the Team first needs to authorize it. |
Adityajparmar37
suggested changes
Jun 10, 2024
| @@ -148,7 +118,7 @@ function Login() { | |||
|
|
|||
| <div className="relative mb-4"> | |||
| <input | |||
| required | |||
There was a problem hiding this comment.
Why did you remove required ?? it is important to have password
src/pages/Signup.jsx
Outdated
| @@ -165,7 +167,7 @@ function Signup() { | |||
|
|
|||
| <div className="mb-4"> | |||
| <input | |||
| required | |||
There was a problem hiding this comment.
Here also why did you remove required
|
Sorry, it was a mistake. I was only testing some cases by removing this. |
|
I've added required in the input field |
Adityajparmar37
approved these changes
Jun 10, 2024
|
Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨ |
hustlerZzZ
added
gssoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses and fixes issue #182, which involves displaying the error message from the backend in a toast notification upon login and signup failure.
Fixes #182
Type of change
Please give a X on it which is applicable
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test A Describe here
Test B Describe here (if Requred)
Screenshorts and Vedios:
give screenshorts and vedio of the changes you made
Checklist:
give a X on it which is applicable