Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/259 vertical center show password icon #271

Conversation

Saksham2k3s
Copy link
Contributor

This PR addresses the alignment issue of the "Show Password" icon in the password field, ensuring that the icon is vertically centered within the input field.

Fixes #259

Type of change

Please give a X on it which is applicable

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A Describe here

Test B Describe here (if Requred)

Screenshorts and Vedios:

Before
image

After
show-pass-icon

Checklist:

give a X on it which is applicable

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jun 8, 2024

@Saksham2k3s is attempting to deploy a commit to the vansh69's projects Team on Vercel.

A member of the Team first needs to authorize it.

@hustlerZzZ hustlerZzZ merged commit 4e77943 into VanshKing30:main Jun 9, 2024
0 of 2 checks passed
Copy link

github-actions bot commented Jun 9, 2024

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Show Password Icon in Password Field Is Not Vertically Centered
2 participants