Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: arm64環境でDockerが動作しない問題へのワークアラウンド #806

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

sabonerune
Copy link
Contributor

@sabonerune sabonerune commented Dec 2, 2023

内容

arm64環境でDockerが動作しない問題への一時的な対処を行います。

soundfile側でarm64のバイナリを配布することが最も良いことだと思います。
しかし作業が進んでいる様子がなく0.15リリースまでに間に合わないような気がしますので先に対処を行います。

関連 Issue

@sabonerune sabonerune requested a review from a team as a code owner December 2, 2023 15:22
@sabonerune sabonerune requested review from Hiroshiba and removed request for a team December 2, 2023 15:22
Copy link

github-actions bot commented Dec 2, 2023

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 480 326 coverage-32%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 23 0 coverage-100%
voicevox_engine/cancellable_engine.py 91 71 coverage-22%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 27 12 coverage-56%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/library_manager.py 93 5 coverage-95%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 29 12 coverage-59%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 162 9 coverage-94%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/morphing.py 70 46 coverage-34%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 19 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 201 146 coverage-27%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 59 30 coverage-49%
voicevox_engine/synthesis_engine/synthesis_engine.py 129 11 coverage-91%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 144 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 10 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 2180 706 coverage-68%

@Hiroshiba Hiroshiba changed the title FIX: arm64環境でDocerが動作しない問題へのワークアラウンド FIX: arm64環境でDockerが動作しない問題へのワークアラウンド Dec 3, 2023
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ワークアラウンドになるとは思いますが、一旦この形が丸いのかなと思いました!
arm64でだけインストールする形が一番適してそうですが、まあif分岐書くのも大変ですし一旦とりあえずインストールする形で良いのかなと。

libsndfile周りに尽力してくださっている @aoirint さんにも共有です・・・!

@Hiroshiba Hiroshiba merged commit dbb40f2 into VOICEVOX:master Dec 3, 2023
3 checks passed
@sabonerune sabonerune deleted the fix/docker-arm-libsndfile branch December 3, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants