Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PytestCollectionWarningを解消する #1441

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

sabonerune
Copy link
Contributor

内容

pytest実行時にDeprecationWarningが発生する問題を修正します。

その他

TestModelというクラス名がテストコードであると判定されていることが原因でした。
とりあえず_TestModelにリネームして修正します。
https://docs.pytest.org/en/8.2.x/explanation/goodpractices.html#test-discovery

@sabonerune sabonerune requested a review from a team as a code owner June 26, 2024 15:13
@sabonerune sabonerune requested review from Hiroshiba and removed request for a team June 26, 2024 15:13
Copy link
Contributor

@tarepan tarepan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍️

warning が正しく解消しています。また warning の総量が減ることで新規 warning 発生時により目立つと期待できます。good work!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit 8ae578a into VOICEVOX:master Jun 27, 2024
4 checks passed
@sabonerune sabonerune deleted the fix/pytest-collection-warning branch June 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants