Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ソング:再生位置の表示形式を変更できるようにする #2306

Merged
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
9f648aa
MBSR形式で表示するように変更、秒とMBSRどちらで表示するかを切り替えられるようにした
sigprogramming Oct 19, 2024
63336c1
拍と16分が1始まりになるように修正、コメントを追加
sigprogramming Oct 19, 2024
c41505b
修正、MBSRからMBSに変更
sigprogramming Oct 19, 2024
4563324
tickからMBSに変換する処理をdomain.tsに移動
sigprogramming Oct 19, 2024
4e9c638
変数名とclass名を変更
sigprogramming Oct 19, 2024
6c35780
小節.拍.100分に変更、MBS型からMeasuresBeats型に変更
sigprogramming Oct 22, 2024
840eab3
右クリックメニューの表記を変更
sigprogramming Oct 22, 2024
613cf65
再生ヘッド位置の表示モードが設定として保存されるようにした
sigprogramming Oct 22, 2024
725d0d0
デフォルトの表示モードを秒に変更[update snapshots]
sigprogramming Oct 22, 2024
f370ccb
displayModeからdisplayFormatに変更、リファクタリング
sigprogramming Oct 23, 2024
802a8f0
関数を削除
sigprogramming Oct 24, 2024
13365c1
Update src/components/Sing/PlayheadPositionDisplay.vue
sigprogramming Oct 24, 2024
4055aca
再生ヘッド位置の取得・設定処理をコンポーザブル化
sigprogramming Oct 24, 2024
06a8af7
SCREAMING_SNAKE_CASEに変更
sigprogramming Oct 24, 2024
3f9f201
修正
sigprogramming Oct 24, 2024
aa96997
Merge branch 'main' into display_playhead_position_in_mbsr_format
sigprogramming Oct 24, 2024
a52bd76
playheadPositionをRefにして、FrequentlyUpdatedStateとusePlayheadPositionを削除
sigprogramming Oct 26, 2024
6c3e1c2
MeasuresBeatsを移動
sigprogramming Oct 28, 2024
c6eeed2
PLAYHEAD_POSITIONの同期処理を削除
sigprogramming Oct 28, 2024
ba88ed9
displayFormatのチェックを行っているところを削除、importのところが変更できていなかったので修正
sigprogramming Oct 28, 2024
dd7c1b4
tpqnのバリデーション処理が間違っていたので修正
sigprogramming Oct 28, 2024
4d63b33
// オートスクロールの位置変更
Hiroshiba Oct 28, 2024
83fc8ba
Merge remote-tracking branch 'upstream/main' into pr/sigprogramming/2…
Hiroshiba Oct 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 160 additions & 0 deletions src/components/Sing/PlayheadPositionDisplay.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
<template>
<div>
<div v-if="displayFormat === 'MinutesSeconds'" class="playhead-position">
<div>{{ minAndSecStr }}</div>
<div class="millisec">.{{ milliSecStr }}</div>
</div>
<div v-if="displayFormat === 'MeasuresBeats'" class="playhead-position">
<div>{{ measuresStr }}.</div>
<div>{{ beatsIntegerPartStr }}</div>
<div class="beats-fractional-part">.{{ beatsFractionalPartStr }}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(割とただのコメントです)

ここの更新速度が早すぎて、若干目が使えるなと感じました!
ただまあ、別にこれでいい感じなのかなーとも思ってます。どうしようもない!

</div>
<ContextMenu ref="contextMenu" :menudata="contextMenuData" />
</div>
</template>

<script setup lang="ts">
import { ref, computed, onMounted, onUnmounted } from "vue";
import { useStore } from "@/store";
import ContextMenu, {
ContextMenuItemData,
} from "@/components/Menu/ContextMenu.vue";
import { getTimeSignaturePositions, ticksToMeasuresBeats } from "@/sing/domain";
import { MeasuresBeats } from "@/store/type";
import { useRootMiscSetting } from "@/composables/useRootMiscSetting";

const store = useStore();

const playheadTicks = ref(0);
const [displayFormat, setDisplayFormat] = useRootMiscSetting(
store,
"playheadPositionDisplayFormat",
);

const timeSignatures = computed(() => {
const tpqn = store.state.tpqn;
const timeSignatures = store.state.timeSignatures;
const tsPositions = getTimeSignaturePositions(timeSignatures, tpqn);
return timeSignatures.map((value, index) => ({
...value,
position: tsPositions[index],
}));
});

const measuresBeats = computed((): MeasuresBeats => {
if (displayFormat.value !== "MeasuresBeats") {
return { measures: 1, beats: 1 };
}
const tpqn = store.state.tpqn;
return ticksToMeasuresBeats(playheadTicks.value, timeSignatures.value, tpqn);
});

const measuresStr = computed(() => {
return measuresBeats.value.measures >= 0
? String(measuresBeats.value.measures).padStart(3, "0")
: String(measuresBeats.value.measures);
});

const beatsIntegerPartStr = computed(() => {
const integerPart = Math.floor(measuresBeats.value.beats);
return String(integerPart).padStart(2, "0");
});

const beatsFractionalPartStr = computed(() => {
const integerPart = Math.floor(measuresBeats.value.beats);
const fractionalPart = Math.floor(
(measuresBeats.value.beats - integerPart) * 100,
);
return String(fractionalPart).padStart(2, "0");
});

const minAndSecStr = computed(() => {
if (displayFormat.value !== "MinutesSeconds") {
return "";
}
const ticks = playheadTicks.value;
const time = store.getters.TICK_TO_SECOND(ticks);
const intTime = Math.trunc(time);
const min = Math.trunc(intTime / 60);
const minStr = String(min).padStart(2, "0");
const secStr = String(intTime - min * 60).padStart(2, "0");
return `${minStr}:${secStr}`;
});

const milliSecStr = computed(() => {
if (displayFormat.value !== "MinutesSeconds") {
return "";
}
const ticks = playheadTicks.value;
const time = store.getters.TICK_TO_SECOND(ticks);
const intTime = Math.trunc(time);
const milliSec = Math.trunc((time - intTime) * 1000);
const milliSecStr = String(milliSec).padStart(3, "0");
return milliSecStr;
});

const contextMenu = ref<InstanceType<typeof ContextMenu>>();
const contextMenuData = computed<ContextMenuItemData[]>(() => {
return [
{
type: "button",
label: "小節.拍",
disabled: displayFormat.value === "MeasuresBeats",
onClick: async () => {
contextMenu.value?.hide();
setDisplayFormat("MeasuresBeats");
},
disableWhenUiLocked: false,
},
{
type: "button",
label: "分:秒",
disabled: displayFormat.value === "MinutesSeconds",
onClick: async () => {
contextMenu.value?.hide();
setDisplayFormat("MinutesSeconds");
},
disableWhenUiLocked: false,
},
sigprogramming marked this conversation as resolved.
Show resolved Hide resolved
];
});

const playheadPositionChangeListener = (position: number) => {
playheadTicks.value = position;
};

onMounted(() => {
void store.dispatch("ADD_PLAYHEAD_POSITION_CHANGE_LISTENER", {
listener: playheadPositionChangeListener,
});
});

onUnmounted(() => {
void store.dispatch("REMOVE_PLAYHEAD_POSITION_CHANGE_LISTENER", {
listener: playheadPositionChangeListener,
});
});
sigprogramming marked this conversation as resolved.
Show resolved Hide resolved
</script>

<style scoped lang="scss">
@use "@/styles/v2/variables" as vars;
@use "@/styles/colors" as colors;

.playhead-position {
align-items: center;
display: flex;
font-weight: 700;
font-size: 28px;
color: var(--scheme-color-on-surface);
}

.millisec {
font-size: 16px;
margin: 10px 0 0 2px;
}

.beats-fractional-part {
font-size: 16px;
margin: 10px 0 0 2px;
}
</style>
62 changes: 3 additions & 59 deletions src/components/Sing/ToolBar/ToolBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,7 @@
icon="stop"
@click="stop"
/>
<div class="sing-playhead-position">
<div>{{ playheadPositionMinSecStr }}</div>
<div class="sing-playhead-position-millisec">
.{{ playHeadPositionMilliSecStr }}
</div>
</div>
<PlayheadPositionDisplay class="sing-playhead-position" />
</div>
<!-- settings for edit controls -->
<div class="sing-controls">
Expand Down Expand Up @@ -164,7 +159,8 @@
</template>

<script setup lang="ts">
import { computed, watch, ref, onMounted, onUnmounted } from "vue";
import { computed, watch, ref } from "vue";
import PlayheadPositionDisplay from "../PlayheadPositionDisplay.vue";
import EditTargetSwicher from "./EditTargetSwicher.vue";
import { useStore } from "@/store";

Expand Down Expand Up @@ -383,30 +379,6 @@ const setVolumeRangeAdjustment = () => {
});
};

const playheadTicks = ref(0);

/// 再生時間の分と秒
const playheadPositionMinSecStr = computed(() => {
const ticks = playheadTicks.value;
const time = store.getters.TICK_TO_SECOND(ticks);

const intTime = Math.trunc(time);
const min = Math.trunc(intTime / 60);
const minStr = String(min).padStart(2, "0");
const secStr = String(intTime - min * 60).padStart(2, "0");

return `${minStr}:${secStr}`;
});

const playHeadPositionMilliSecStr = computed(() => {
const ticks = playheadTicks.value;
const time = store.getters.TICK_TO_SECOND(ticks);
const intTime = Math.trunc(time);
const milliSec = Math.trunc((time - intTime) * 1000);
const milliSecStr = String(milliSec).padStart(3, "0");
return milliSecStr;
});

const nowPlaying = computed(() => store.state.nowPlaying);

const play = () => {
Expand Down Expand Up @@ -463,22 +435,6 @@ const snapTypeSelectModel = computed({
});
},
});

const playheadPositionChangeListener = (position: number) => {
playheadTicks.value = position;
};

onMounted(() => {
void store.dispatch("ADD_PLAYHEAD_POSITION_CHANGE_LISTENER", {
listener: playheadPositionChangeListener,
});
});

onUnmounted(() => {
void store.dispatch("REMOVE_PLAYHEAD_POSITION_CHANGE_LISTENER", {
listener: playheadPositionChangeListener,
});
});
</script>

<style scoped lang="scss">
Expand Down Expand Up @@ -714,19 +670,7 @@ onUnmounted(() => {
}

.sing-playhead-position {
align-items: center;
display: flex;
font-size: 28px;
font-weight: 700;
margin-left: 16px;
color: var(--scheme-color-on-surface);
}

.sing-playhead-position-millisec {
font-size: 16px;
font-weight: 700;
margin: 10px 0 0 2px;
color: var(--scheme-color-on-surface);
}

.sing-controls {
Expand Down
48 changes: 46 additions & 2 deletions src/sing/domain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
PhraseKey,
Track,
EditorFrameAudioQuery,
MeasuresBeats,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ただのコメントです)

domainからstoreの型をimportしてるの、逆な気がしますね!!

今回のこの型に関してはstore側で全く使ってないので、多分こっちに定義する方が良さそう感あります。
まあ、いずれ移動すると良さそう・・・!
(src/sing/type.tsとかにでも。)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TempoTimeSignatureの型もsrc/store/type.tsで定義していますが、domain.tsで型を定義してsrc/store/type.tsでインポートする形が良いでしょうか?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

個人的にはそちらの方があってるように感じます!

解釈としては、

  • store/typeはVuexのStoreの中で出てくるtype
    • が理想な気がするけど、現状いろんなものが置かれまくってしまっている・・・!
  • domain/sing
    • 何をドメインとするかわからないけど、少なくとも音楽や歌系の単位や型はここに置いても良さそう
    • domainはレイヤードアーキテクチャ的にはいろんなものから参照されて良いものなので、こっちを上流にすると良さそう

みたいな感じかなと!
ただ色々移動になってしまうと思うので、一旦このプリリクエストじゃないほうが良いのかもな~と思い、とりあえずコメントしてみた感じです!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほどです!
ひとまずMeasuresBeatsのみdomain.tsに移しました!

} from "@/store/type";
import { FramePhoneme } from "@/openapi";
import { TrackId } from "@/type/preload";
Expand Down Expand Up @@ -210,10 +211,53 @@ export function getMeasureDuration(
beatType: number,
tpqn: number,
) {
const wholeNoteDuration = tpqn * 4;
return (wholeNoteDuration / beatType) * beats;
return ((tpqn * 4) / beatType) * beats;
}

// NOTE: 戻り値の単位はtick
export function getBeatDuration(beatType: number, tpqn: number) {
return (tpqn * 4) / beatType;
}

const findTimeSignatureIndex = (
ticks: number,
timeSignatures: (TimeSignature & { position: number })[],
) => {
if (ticks < 0) {
return 0;
}
for (let i = 0; i < timeSignatures.length - 1; i++) {
if (
timeSignatures[i].position <= ticks &&
timeSignatures[i + 1].position > ticks
) {
return i;
}
}
return timeSignatures.length - 1;
};

export const ticksToMeasuresBeats = (
ticks: number,
timeSignatures: (TimeSignature & { position: number })[],
tpqn: number,
): MeasuresBeats => {
const tsIndex = findTimeSignatureIndex(ticks, timeSignatures);
const ts = timeSignatures[tsIndex];

const measureDuration = getMeasureDuration(ts.beats, ts.beatType, tpqn);
const beatDuration = getBeatDuration(ts.beatType, tpqn);

const posInTs = ticks - ts.position;
const measuresInTs = Math.floor(posInTs / measureDuration);
const measures = ts.measureNumber + measuresInTs;

const posInMeasure = posInTs - measureDuration * measuresInTs;
const beats = 1 + posInMeasure / beatDuration;

return { measures, beats };
};

export function getNumMeasures(
notes: Note[],
tempos: Tempo[],
Expand Down
2 changes: 2 additions & 0 deletions src/store/setting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export const settingStoreState: SettingStoreState = {
panAndGain: true,
},
showSingCharacterPortrait: true,
playheadPositionDisplayFormat: "MinutesSeconds",
};

export const settingStore = createPartialStore<SettingStoreTypes>({
Expand Down Expand Up @@ -141,6 +142,7 @@ export const settingStore = createPartialStore<SettingStoreTypes>({
"skipUpdateVersion",
"undoableTrackOperations",
"showSingCharacterPortrait",
"playheadPositionDisplayFormat",
] as const;

// rootMiscSettingKeysに値を足し忘れていたときに型エラーを出す検出用コード
Expand Down
5 changes: 5 additions & 0 deletions src/store/type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -827,6 +827,11 @@ export type SongExportSetting = {
withTrackParameters: TrackParameters;
};

export type MeasuresBeats = {
measures: number;
beats: number;
};

export type SingingStoreState = {
tpqn: number; // Ticks Per Quarter Note
tempos: Tempo[];
Expand Down
3 changes: 3 additions & 0 deletions src/type/preload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,9 @@ export const rootMiscSettingSchema = z.object({
})
.default({}),
showSingCharacterPortrait: z.boolean().default(true), // ソングエディタで立ち絵を表示するか
playheadPositionDisplayFormat: z
.enum(["MinutesSeconds", "MeasuresBeats"])
sigprogramming marked this conversation as resolved.
Show resolved Hide resolved
.default("MinutesSeconds"), // 再生ヘッド位置の表示モード
});
export type RootMiscSettingType = z.infer<typeof rootMiscSettingSchema>;

Expand Down
Loading