-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
launch vkcom on k2 #1129
Merged
Merged
launch vkcom on k2 #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrophysik
force-pushed
the
vsadokhov/launch-k2-vkcom
branch
from
October 29, 2024 14:05
21cf56c
to
7978d90
Compare
astrophysik
force-pushed
the
vsadokhov/launch-k2-vkcom
branch
3 times, most recently
from
November 2, 2024 08:59
ac5836f
to
9f41aa2
Compare
astrophysik
force-pushed
the
vsadokhov/launch-k2-vkcom
branch
from
November 2, 2024 12:54
5dcba1c
to
3538190
Compare
astrophysik
commented
Nov 2, 2024
@@ -103,6 +103,10 @@ void *RuntimeAllocator::realloc_script_memory(void *mem, size_t new_size, size_t | |||
|
|||
void RuntimeAllocator::free_script_memory(void *mem, size_t size) noexcept { | |||
php_assert(size); | |||
if (unlikely(!is_script_allocator_available())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add it because temporary objects are created during the image creation step
apolyakov
requested changes
Nov 5, 2024
apolyakov
previously approved these changes
Nov 6, 2024
mkornaukhov03
requested changes
Nov 6, 2024
mkornaukhov03
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pr adds allows you to launch the web-site on K2
#ifndef K2
to implement the new k2 specific biltins in php code