Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: pr7705 in v6 #7912

Merged
merged 1 commit into from
Nov 7, 2024
Merged

patch: pr7705 in v6 #7912

merged 1 commit into from
Nov 7, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov
feat: add tests ids props for Calendar, CalendarRange, DateInputRange…
f49f9e9 
…, DateInput (#7705)

* feat: add tests ids props for Calendar, CalendarRange, DateInputRange, DateInput

* fix(CalendarRange): fix tests

* fix: fix tests after merge conflicts

(cherry picked from commit 12e1d2b)
@EldarMuhamethanov EldarMuhamethanov self-assigned this Nov 7, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 7, 2024 10:59
@EldarMuhamethanov EldarMuhamethanov changed the title patch: pr7705 patch: pr7705 in v6 Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

size-limit report 📦

Path Size
JS 387.16 KB (+0.43% 🔺)
JS (gzip) 116.96 KB (+0.34% 🔺)
JS (brotli) 96.11 KB (+0.46% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 331.15 KB (0%)
CSS (gzip) 41.35 KB (0%)
CSS (brotli) 32.69 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

👀 Docs deployed

Commit f49f9e9

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (66405d2) to head (f49f9e9).
Report is 17 commits behind head on v6.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v6    #7912      +/-   ##
==========================================
- Coverage   95.20%   95.18%   -0.02%     
==========================================
  Files         383      383              
  Lines       11340    11363      +23     
  Branches     3723     3746      +23     
==========================================
+ Hits        10796    10816      +20     
- Misses        544      547       +3
Flag Coverage Δ
unittests 95.18% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon mentioned this pull request Nov 7, 2024
Merged
andrey-medvedev-vk
andrey-medvedev-vk approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@EldarMuhamethanov EldarMuhamethanov merged commit 3433f8c into v6 Nov 7, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the patch/pr7705-v6 branch November 7, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
None yet
Projects
VKUI
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EldarMuhamethanov @inomdzhon @andrey-medvedev-vk