-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Clickable): use correct CSS property values #7908
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А давай перенесем -webkit-tap-highlight-color в realClickable так как оно на div тоже показывается
Также подумал что getUserAgentResetClassName можно из js унести в css
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7908 +/- ##
==========================================
- Coverage 95.36% 95.34% -0.03%
==========================================
Files 378 378
Lines 11165 11173 +8
Branches 3712 3725 +13
==========================================
+ Hits 10648 10653 +5
- Misses 517 520 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit 843eab2 |
9a72112
Co-authored-by: Daniil Suvorov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Описание
Поправил значения свойства
-webkit-tap-highlight-color
на валидноеtransparent
вместоnone
.UPD
см. #7908 (review)
-webkit-tap-highlight-color
в.realClicable
;getUserAgentResetClassName
в CSS – увеличили специфичность, но для этих стилей допустимоRelease notes
Исправления