Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Clickable): use correct CSS property values #7908

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Nov 7, 2024

  • Release notes

Описание

Поправил значения свойства -webkit-tap-highlight-color на валидное transparent вместо none.

UPD

см. #7908 (review)

  • перенёс -webkit-tap-highlight-color в .realClicable;
  • перенёс логику getUserAgentResetClassName в CSS – увеличили специфичность, но для этих стилей допустимо

Release notes

Исправления

  • Tappable: в кликабельных компонентах исправлена проблема, когда при касании через тач появлялся системный оверлей

@inomdzhon inomdzhon added this to the v7.0.0-beta.2 milestone Nov 7, 2024
@inomdzhon inomdzhon self-assigned this Nov 7, 2024
@inomdzhon inomdzhon requested a review from a team as a code owner November 7, 2024 10:05
Copy link
Contributor

github-actions bot commented Nov 7, 2024

size-limit report 📦

Path Size
JS 385.11 KB (-0.04% 🔽)
JS (gzip) 123.07 KB (-0.04% 🔽)
JS (brotli) 101.97 KB (-0.05% 🔽)
JS import Div (tree shaking) 1.47 KB (0%)
CSS 342.28 KB (+0.01% 🔺)
CSS (gzip) 49.32 KB (-0.05% 🔽)
CSS (brotli) 39.96 KB (-0.09% 🔽)

Copy link
Contributor

@SevereCloud SevereCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А давай перенесем -webkit-tap-highlight-color в realClickable так как оно на div тоже показывается

Также подумал что getUserAgentResetClassName можно из js унести в css

Copy link

codesandbox-ci bot commented Nov 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

SevereCloud
SevereCloud previously approved these changes Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

e2e tests

Playwright Report

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (3661e98) to head (843eab2).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7908      +/-   ##
==========================================
- Coverage   95.36%   95.34%   -0.03%     
==========================================
  Files         378      378              
  Lines       11165    11173       +8     
  Branches     3712     3725      +13     
==========================================
+ Hits        10648    10653       +5     
- Misses        517      520       +3     
Flag Coverage Δ
unittests 95.34% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

👀 Docs deployed

Commit 843eab2

BlackySoul
BlackySoul previously approved these changes Nov 7, 2024
@inomdzhon inomdzhon dismissed stale reviews from BlackySoul and SevereCloud via 9a72112 November 7, 2024 10:24
BlackySoul
BlackySoul previously approved these changes Nov 7, 2024
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@inomdzhon inomdzhon merged commit 3751c47 into master Nov 7, 2024
25 of 28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/Clickable-style branch November 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants