Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): Bump eslint-plugin-react-compiler from 0.0.0-experimental-56229e1-20240813 to 0.0.0-experimental-7670337-20240918 in the eslint group #7886

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps the eslint group with 1 update: eslint-plugin-react-compiler.

Updates eslint-plugin-react-compiler from 0.0.0-experimental-56229e1-20240813 to 0.0.0-experimental-7670337-20240918

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the eslint group with 1 update: [eslint-plugin-react-compiler](https://github.com/facebook/react/tree/HEAD/compiler/packages/eslint-plugin-react-compiler).


Updates `eslint-plugin-react-compiler` from 0.0.0-experimental-56229e1-20240813 to 0.0.0-experimental-7670337-20240918
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/HEAD/compiler/packages/eslint-plugin-react-compiler)

---
updated-dependencies:
- dependency-name: eslint-plugin-react-compiler
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner November 4, 2024 05:49
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 4, 2024
@dependabot dependabot bot requested a review from a team November 4, 2024 05:49
Copy link

codesandbox-ci bot commented Nov 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

size-limit report 📦

Path Size
JS 382.59 KB (0%)
JS (gzip) 122.42 KB (0%)
JS (brotli) 101.37 KB (0%)
JS import Div (tree shaking) 1.47 KB (0%)
CSS 342.2 KB (0%)
CSS (gzip) 49.32 KB (0%)
CSS (brotli) 39.95 KB (0%)

Copy link
Contributor

github-actions bot commented Nov 4, 2024

e2e tests

Playwright Report

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (667b25d) to head (eca463e).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7886   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         376      376           
  Lines       11043    11043           
  Branches     3664     3664           
=======================================
  Hits        10531    10531           
  Misses        512      512           
Flag Coverage Δ
unittests 95.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

👀 Docs deployed

Commit fa08668

- `CustomSelect` жалуется на `renderOption` в 729 строке, что якобы идёт обращение к `ref.current`, но такого там нет;
    ```plain
    729:51  error  Ref values (the `current` property) may not be accessed during render. (https://react.dev/reference/react/useRef)  react-compiler/react-compiler
    ```
- `ModalRootContext` и `useModalManager` переписываются в PR #6759.
@inomdzhon
Copy link
Contributor

image

локальный лог ошибок

Заигнорил эти ошибки, причину описал в коммите eca463e

@inomdzhon
Copy link
Contributor

inomdzhon commented Nov 5, 2024

image _локальный лог ошибок_

Заигнорил эти ошибки, причину описал в коммите eca463e

Запустил очистив .eslintcache – ошибок побольше оказывается. Жалуется на обращение к .current в теле функции во всех других местах. Собственно, фиксы под предыдущие версии плагина, связанные с Refs, в новых версиях сейчас не валидны (#6920).

PR закрываю.

@inomdzhon inomdzhon closed this Nov 5, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 5, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@inomdzhon inomdzhon deleted the dependabot/npm_and_yarn/eslint-f730d89f5c branch November 5, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant