Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Calendar): rename onClose prop to onDoneButtonClick #7880

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • Release notes
  • Codemod

Описание

Сейчас у компонента Calendar есть свойство onClose - колбэк, который срабатыват при нажатии на кнопку "Done". Данное название свойства нужно переименовать. Почему? onClose слишком конкретное название, получается что Calendar знает о том, что он может закрыться, а так быть не должно, сам по себе календарь, если он не используется в DateInput не обязательно должен закрываться. Нужно придумать более абстрактное название для этого свойства

Изменения

В компоненте Calendar переименовал свойство onClose на onDoneButtonClick

Release notes

BREAKING CHANGE

  • Calendar: свойство onClose переименовано на onDoneButtonClick

Copy link
Contributor

github-actions bot commented Nov 1, 2024

size-limit report 📦

Path Size
JS 382.47 KB (+0.02% 🔺)
JS (gzip) 122.39 KB (+0.02% 🔺)
JS (brotli) 101.38 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.47 KB (0%)
CSS 342.2 KB (0%)
CSS (gzip) 49.32 KB (0%)
CSS (brotli) 39.95 KB (0%)

Copy link

codesandbox-ci bot commented Nov 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 1, 2024

👀 Docs deployed

Commit e95e660

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (ebb46a5) to head (e95e660).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7880   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files         376      376           
  Lines       11041    11041           
  Branches     3664     3664           
=======================================
  Hits        10508    10508           
  Misses        533      533           
Flag Coverage Δ
unittests 95.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit 0701c36 into master Nov 5, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/calendar-rename-onClose-prop branch November 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants